sebgab
1 Followers · 2 Following
Repositories
10
 Projects Packages Public Activity Starred Repositories
sebgab merged pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-30 08:37:29 +00:00
Merge I2C command handler into main
91cffd78f4 Move data initialization into write, as it is only needed there
sebgab opened issue Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#22 2024-04-28 18:43:53 +00:00
Add logic to only get the value on first read
sebgab opened issue Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#21 2024-04-28 18:39:34 +00:00
Verify that last action write is needed
sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-28 18:27:43 +00:00
Merge I2C command handler into main

Closes #17

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-28 18:24:50 +00:00
Merge I2C command handler into main

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-28 18:24:41 +00:00
Merge I2C command handler into main

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-28 18:24:28 +00:00
Merge I2C command handler into main

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-28 18:24:19 +00:00
Merge I2C command handler into main

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e

4666f79dd3 Init the fan history as 0 and add Ina to authors in main
d31f03b6c7 Delete unused EEPROM code & update comments
6acdb2beb6 Rename receive buffer for better clarity & add comment
ba54ff20ef Fix master slave naming and remove dead code
8f61e6b998 Validate that we do not overflow the receive buffer
Compare 5 commits »
sebgab closed issue Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#20 2024-04-28 18:23:53 +00:00
Ensure I2C write buffer does not overflow
sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-28 18:19:18 +00:00
Merge I2C command handler into main

pos is data position, aka how many bytes into the readable area you want to read.

sebgab opened issue Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#20 2024-04-28 18:01:42 +00:00
Ensure I2C write buffer does not overflow
sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-28 12:40:48 +00:00
fanspeed-comparator

Remove commented out code

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-28 12:40:48 +00:00
fanspeed-comparator

We should not have both timer period and timer period ms. ms should be calculated from seconds, or the other way around.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-28 12:40:48 +00:00
fanspeed-comparator

This function should still take in the variable, not use a global variable.

sebgab suggested changes for Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-28 12:40:48 +00:00
fanspeed-comparator

Just one more thing

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

The last E should be removed.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

fanports is a bit confusing, maybe rename to fan_gpio?

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

ac0 and ac1 should be captialized, such that they are AC0.