Mikrokontrollersystemer-gruppe-4/mikrokontrollersystemer-prosjekt
1
0
Fork 0
Code Issues 3 Pull Requests 1 Packages Projects 1 Releases Wiki Activity

Ensure I2C write buffer does not overflow #20

New Issue
Closed
opened 2024-04-28 18:01:42 +00:00 by sebgab · 0 comments
sebgab commented 2024-04-28 18:01:42 +00:00
Owner
Copy Link

prosjekt.X/i2c.c Line 54 in ae1c50ee09
void i2c_write_handler(uint8_t data) {

The write does not check if the buffer will overflow and will cause an issue if the master sends too much data.
This should be fixed.

https://code.e1m1.xyz/Mikrokontrollersystemer-gruppe-4/mikrokontrollersystemer-prosjekt/src/commit/ae1c50ee09f2a64f93c0e17cbeefae3c338c1ea7/prosjekt.X/i2c.c#L54 The write does not check if the buffer will overflow and will cause an issue if the master sends too much data. This should be fixed.
sebgab added the
bug
 label 2024-04-28 18:01:42 +00:00
sebgab self-assigned this 2024-04-28 18:01:42 +00:00
sebgab added the due date 2024-04-29 2024-04-28 18:02:25 +00:00
Sign in to join this conversation.
output-fan-data-over-i2c
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sebgab
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2024-04-29

Dependencies

No dependencies set.

Reference: Mikrokontrollersystemer-gruppe-4/mikrokontrollersystemer-prosjekt#20
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?