Add logic to only get the value on first read #22

New Issue

sebgab · 2024-04-28T18:43:53Z

sebgab commented

2024-04-28 18:43:53 +00:00

		prosjekt.X/command-handler.c
		Line 227 in 4666f79dd3
	
				        uint16_t v_therm = thermistor_voltage_read();

We should consider adding logic to only do calculations on the first read.
It is a bit odd to do it on both as the data could have changed between the first and second read, it is not likely, but a better way to do it nonetheless.

https://code.e1m1.xyz/Mikrokontrollersystemer-gruppe-4/mikrokontrollersystemer-prosjekt/src/commit/4666f79dd32d4581c2da4c88b17813e7076d8418/prosjekt.X/command-handler.c#L227 We should consider adding logic to only do calculations on the first read. It is a bit odd to do it on both as the data could have changed between the first and second read, it is not likely, but a better way to do it nonetheless.

sebgab added the

enhancement

bug

labels 2024-04-28 18:43:53 +00:00

sebgab self-assigned this 2024-04-28 18:43:53 +00:00

sebgab added reference output-fan-data-over-i2c

2024-04-28 18:43:56 +00:00

Sign in to join this conversation.