The great cleanup #40

Merged

sebgab merged 30 commits from the-great-cleanup into main 2026-03-17 14:24:40 +00:00

Conversation 2 Commits 30 Files changed 26 +5916 -5638

sebgab commented 2026-03-15 15:47:48 +00:00

Owner

Copy link

While working on #38 I got annoyed at how messy the code structure is, so I finally got around to doing this...

While working on #38 I got annoyed at how messy the code structure is, so I finally got around to doing this...

sebgab added 9 commits 2026-03-15 15:47:48 +00:00

Move tasks out of system state 76b4e06d26

Update test imports 4bdbd26af2

Move main state handling and interfaces into separate files b02dcff11f

Fix bug in call interface where it refused to add some calls ... ed5153148e

The add call function in the call interface has a big where when adding
a call it cehcked if it has any call with teh same destination and
ignored the direction of the call.

Move tests into their respective files 5a09d590bb

Tidy up, remove a lot of warning messages 38447684ad

Remove several warnings from tests 9837bc6236

Apply automatic cargo clippy fixes e01f89f9de

Fix all warnings, even from Clippy 6b756a4ecd

Athamantis approved these changes 2026-03-16 10:40:18 +00:00

Athamantis left a comment

Owner

Copy link

lgtm

lgtm

sebgab referenced this pull request 2026-03-17 09:33:23 +00:00

fix-sync-issue-two #41

Hemmily requested review from Hemmily 2026-03-17 09:37:14 +00:00

Hemmily approved these changes 2026-03-17 09:52:31 +00:00

sebgab changed title from The great cleanup to WIP: The great cleanup 2026-03-17 11:24:49 +00:00

sebgab added 21 commits 2026-03-17 14:24:28 +00:00

Implement support for running multiple instances of elevator on one PC cff46d2960

Add time de-sync feature for testing on single machine 84a11f7d87

Turn light off if call is done 091dc43da1

Fix inverted check in previous commit 781f5863a6

Remember to update last_update when receiving an update d275283c04

Don't override handling elevator 5d6020f6b6

Add new facilities for debug logging b10ceae7fb

Misc non-working changes, commited for reasons b51c648be0

Delete old system state controller 9c5ba010e9

Fix error where calls_containing would also be true for other's cab calls 82f95d4d44

Change from call mapping to elevator to the elevator mapping to call ... ff2e6a2d18

Previosly each call had a "handling_elevator" field, this has now been
removeed.
To compensate for this the elevator now has a field to track which call
it is currently handling.

Based on initial testing this fixes the issue where calls drop from the
network, I believe the main culprit behind this was due to the elevators
not being able to agree on who was handling each call.
With this change a call can be handled by multiple elevators at once,
even if that is not ideal behaviour in regards to efficiency.

Delete call based on currently serving ID 60177b4968

Fix so elevators will serve calls that are not their own acf4b4e9c8

Merge branch 'main' into fix-sync-issue-two ae033625a7

Remove cargo warnings ba5dd46364

Update assignment to use new call id functions bac1043421

Remove extraneous comments from development c92cb9167e

Remove extra comment 2dcb396358

If the spec doesn't require it, don't do it b69071dbdb

The big typo fix 5ebded3ce5

Merge pull request 'fix-sync-issue-two' (#41) from fix-sync-issue-two into the-great-cleanup ... 671ddd6d9f

Reviewed-on: #41
Reviewed-by: Athamantis <athamantis@noreply@e1m1.xyz>

sebgab changed title from WIP: The great cleanup to The great cleanup 2026-03-17 14:24:32 +00:00

sebgab merged commit bb4fc4b955 into main 2026-03-17 14:24:40 +00:00

sebgab deleted branch the-great-cleanup 2026-03-17 14:24:40 +00:00

sebgab referenced this pull request from a commit 2026-03-17 14:24:41 +00:00

Merge pull request 'The great cleanup' (#40) from the-great-cleanup into main

Sign in to join this conversation.

Reviewers

No reviewers

Athamantis

Hemmily

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

priority

high

  

priority

low

  

priority

medium

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

priority

high

priority

low

priority

medium

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

TTK4145/elevator!40

No description provided.