TTK4145/elevator
3
0
Fork 0
Code Issues 1 Pull requests Projects 4 Releases 1 Packages Wiki Activity Actions

fix-sync-issue-two #41

Merged
sebgab merged 47 commits from fix-sync-issue-two into the-great-cleanup 2026-03-17 14:24:26 +00:00
Conversation 2 Commits 47 Files changed 20 +909 -383
sebgab commented 2026-03-17 09:33:23 +00:00
Owner
Copy link

Depends on #40
Closes #38
Closes #4

Depends on #40 Closes #38 Closes #4
The add call function in the call interface has a big where when adding
a call it cehcked if it has any call with teh same destination and
ignored the direction of the call.
Move tests into their respective files
All checks were successful
/ build_and_test (push) Successful in 30s
Details
/ Static Release Build (push) Has been skipped
Details
5a09d590bb
Fix all warnings, even from Clippy
All checks were successful
/ build_and_test (push) Successful in 30s
Details
/ Static Release Build (push) Has been skipped
Details
6b756a4ecd
Don't override handling elevator
All checks were successful
/ build_and_test (push) Successful in 2m10s
Details
/ Static Release Build (push) Has been skipped
Details
5d6020f6b6
Misc non-working changes, commited for reasons
All checks were successful
/ build_and_test (push) Successful in 2m18s
Details
/ Static Release Build (push) Has been skipped
Details
b51c648be0
Change from call mapping to elevator to the elevator mapping to call
All checks were successful
/ build_and_test (push) Successful in 35s
Details
/ Static Release Build (push) Has been skipped
Details
ff2e6a2d18 
Previosly each call had a "handling_elevator" field, this has now been
removeed.
To compensate for this the elevator now has a field to track which call
it is currently handling.

Based on initial testing this fixes the issue where calls drop from the
network, I believe the main culprit behind this was due to the elevators
not being able to agree on who was handling each call.
With this change a call can be handled by multiple elevators at once,
even if that is not ideal behaviour in regards to efficiency.
Delete call based on currently serving ID
All checks were successful
/ build_and_test (push) Successful in 35s
Details
/ Static Release Build (push) Has been skipped
Details
60177b4968
Fix so elevators will serve calls that are not their own
All checks were successful
/ build_and_test (push) Successful in 35s
Details
/ Static Release Build (push) Has been skipped
Details
acf4b4e9c8
Merge branch 'main' into fix-sync-issue-two
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
ae033625a7
sebgab changed target branch from main to the-great-cleanup 2026-03-17 11:24:33 +00:00
sebgab changed title from WIP: fix-sync-issue-two to fix-sync-issue-two 2026-03-17 11:24:45 +00:00
Update assignment to use new call id functions
All checks were successful
/ build_and_test (push) Successful in 37s
Details
/ Static Release Build (push) Has been skipped
Details
bac1043421
Remove extraneous comments from development
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
c92cb9167e
Hemmily requested changes 2026-03-17 12:36:00 +00:00
src/state/models.rs Outdated
@ -729,23 +755,6 @@ impl ElevatorCall {
}
}
/// Get the elevator currently assigned to handle this call
Hemmily commented 2026-03-17 12:11:22 +00:00
Owner
Copy link

Are these not used in the set_destination() and fetch_call_id() functions?

Are these not used in the set_destination() and fetch_call_id() functions?
sebgab commented 2026-03-17 12:39:40 +00:00
Author
Owner
Copy link

The entire "Handling elevator" field has been removed as it only cause de-sync issues without providing any valuable data.
Instead each elevator now tracks which call they are servicing.

As a result the get_handling_elevator and set_handling_elevator no longer have any value.

The entire "Handling elevator" field has been removed as it only cause de-sync issues without providing any valuable data. Instead each elevator now tracks which call they are servicing. As a result the `get_handling_elevator` and `set_handling_elevator` no longer have any value.
Hemmily commented 2026-03-17 12:40:40 +00:00
Owner
Copy link

image

![image](/attachments/8a694fc6-9ecb-47d6-871f-714b8c9cc40c)
image.png
113 KiB
Hemmily marked this conversation as resolved
src/state/system_state.rs Outdated
@ -138,3 +160,4 @@
info!("Direction of the elevator is set to {:?}", direction);
}
None => {
trace!("Destination of the elevator is set to None",);
Hemmily commented 2026-03-17 12:23:08 +00:00
Owner
Copy link

Double trace, don't need this one

Double trace, don't need this one
sebgab commented 2026-03-17 12:40:21 +00:00
Author
Owner
Copy link

WDYM?

WDYM?
sebgab commented 2026-03-17 12:42:25 +00:00
Author
Owner
Copy link

I take it back, resolved in 2dcb396

I take it back, resolved in 2dcb396
sebgab marked this conversation as resolved
Remove extra comment
All checks were successful
/ build_and_test (push) Successful in 37s
Details
/ Static Release Build (push) Has been skipped
Details
2dcb396358
If the spec doesn't require it, don't do it
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
b69071dbdb
Athamantis approved these changes 2026-03-17 14:12:02 +00:00
The big typo fix
All checks were successful
/ build_and_test (push) Successful in 36s
Details
/ Static Release Build (push) Has been skipped
Details
5ebded3ce5
sebgab merged commit 671ddd6d9f into the-great-cleanup 2026-03-17 14:24:26 +00:00
sebgab deleted branch fix-sync-issue-two 2026-03-17 14:24:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Hemmily
Athamantis
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
priority
medium
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TTK4145/elevator!41
No description provided.