TTK4145/elevator
3
0
Fork 0
Code Issues 1 Pull requests Projects 4 Releases 1 Packages Wiki Activity Actions

doc-comment-updating-emilie #67

Merged
Hemmily merged 5 commits from doc-comment-updating-emilie into main 2026-03-18 19:55:44 +00:00
Conversation 4 Commits 5 Files changed 8 +21 -15
Hemmily commented 2026-03-18 19:42:04 +00:00
Owner
Copy link
No description provided.
Closes #55
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
8474c1315d
Remove NOTE and TODO comments from update_unchecked
All checks were successful
/ build_and_test (push) Successful in 39s
Details
/ Static Release Build (push) Has been skipped
Details
9383d7fcaa 
Closes #57 as the NOTE was removed, but created #66 to track the problem
in the future.
Remove TODO and rewrite comments to not use "we"
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
b7ecd8838b 
Closes #50
Athamantis approved these changes 2026-03-18 19:47:05 +00:00
Dismissed
sebgab requested changes 2026-03-18 19:47:17 +00:00
Dismissed
sebgab left a comment
Owner
Copy link

Couple minor things

Couple minor things
src/tasks/button_handler.rs Outdated
@ -1,4 +1,5 @@
#![allow(dead_code)]
//! This module handles what buttons are clicked in the elevator system
sebgab commented 2026-03-18 19:45:05 +00:00
Owner
Copy link

clicked -> pressed

Also consider changing to something along the lines of:
Monitors the elevator buttons and updates the state accordingly

clicked -> pressed Also consider changing to something along the lines of: Monitors the elevator buttons and updates the state accordingly
Hemmily commented 2026-03-18 19:51:17 +00:00
Author
Owner
Copy link

I like this one more image

I like this one more ![image](/attachments/974e690c-6354-413a-b23e-389652de75c3)
image.png
268 KiB
Hemmily marked this conversation as resolved
src/tasks/elevator_controller.rs Outdated
@ -1,3 +1,5 @@
//! This module handles the elevator knowing what floor it is on and moving the elevator when it is safe to do so
sebgab commented 2026-03-18 19:45:56 +00:00
Owner
Copy link

This module handles the elevator knowing what floor it is on

Is this not the floor handler?

> This module handles the elevator knowing what floor it is on Is this not the floor handler?
Hemmily commented 2026-03-18 19:53:06 +00:00
Author
Owner
Copy link

yeah it is more monitoring that it knows (through get_current_floor). Updated slightly to correspond

yeah it is more monitoring that it knows (through get_current_floor). Updated slightly to correspond
Hemmily marked this conversation as resolved
src/tasks/obstruction_handler.rs Outdated
@ -1,11 +1,11 @@
//! This module handles obstructions and communicating if an elevator is obstructed to the elevator server
sebgab commented 2026-03-18 19:46:21 +00:00
Owner
Copy link

It does not handle obstructions, it monitors for obstructions and updates the state

It does not _handle_ obstructions, it monitors for obstructions and updates the state
Hemmily commented 2026-03-18 19:51:32 +00:00
Author
Owner
Copy link

Very true, edited

Very true, edited
Hemmily marked this conversation as resolved
Merge branch 'main' into doc-comment-updating-emilie
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
e989527bf8
Edited based on comments
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
525c74f6d6
Athamantis approved these changes 2026-03-18 19:55:03 +00:00
sebgab approved these changes 2026-03-18 19:55:19 +00:00
Hemmily deleted branch doc-comment-updating-emilie 2026-03-18 19:55:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Athamantis
sebgab
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
priority
medium
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TTK4145/elevator!67
No description provided.