TTK4145/elevator
3
0
Fork 0
Code Issues 1 Pull requests Projects 4 Releases 1 Packages Wiki Activity Actions

set_state_nic_nac #43

Merged
Athamantis merged 8 commits from set_state_nic_nac into main 2026-03-17 14:51:41 +00:00
Conversation 4 Commits 8 Files changed 5 +19 -16
Athamantis commented 2026-03-17 14:20:21 +00:00
Owner
Copy link
No description provided. 
The add call function in the call interface has a big where when adding
a call it cehcked if it has any call with teh same destination and
ignored the direction of the call.
Move tests into their respective files
All checks were successful
/ build_and_test (push) Successful in 30s
Details
/ Static Release Build (push) Has been skipped
Details
5a09d590bb
Fix all warnings, even from Clippy
All checks were successful
/ build_and_test (push) Successful in 30s
Details
/ Static Release Build (push) Has been skipped
Details
6b756a4ecd
Don't override handling elevator
All checks were successful
/ build_and_test (push) Successful in 2m10s
Details
/ Static Release Build (push) Has been skipped
Details
5d6020f6b6
Misc non-working changes, commited for reasons
All checks were successful
/ build_and_test (push) Successful in 2m18s
Details
/ Static Release Build (push) Has been skipped
Details
b51c648be0
Change from call mapping to elevator to the elevator mapping to call
All checks were successful
/ build_and_test (push) Successful in 35s
Details
/ Static Release Build (push) Has been skipped
Details
ff2e6a2d18 
Previosly each call had a "handling_elevator" field, this has now been
removeed.
To compensate for this the elevator now has a field to track which call
it is currently handling.

Based on initial testing this fixes the issue where calls drop from the
network, I believe the main culprit behind this was due to the elevators
not being able to agree on who was handling each call.
With this change a call can be handled by multiple elevators at once,
even if that is not ideal behaviour in regards to efficiency.
Delete call based on currently serving ID
All checks were successful
/ build_and_test (push) Successful in 35s
Details
/ Static Release Build (push) Has been skipped
Details
60177b4968
Fix so elevators will serve calls that are not their own
All checks were successful
/ build_and_test (push) Successful in 35s
Details
/ Static Release Build (push) Has been skipped
Details
acf4b4e9c8
Merge branch 'main' into fix-sync-issue-two
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
ae033625a7
Update assignment to use new call id functions
All checks were successful
/ build_and_test (push) Successful in 37s
Details
/ Static Release Build (push) Has been skipped
Details
bac1043421
Remove extraneous comments from development
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
c92cb9167e
make the set state await for obstruction
Some checks failed
/ build_and_test (push) Failing after 35s
Details
/ Static Release Build (push) Has been skipped
Details
ce55235be5
Athamantis changed title from set_state_nic_nac to WIP: set_state_nic_nac 2026-03-17 14:20:23 +00:00
remove prints
Some checks failed
/ build_and_test (push) Failing after 35s
Details
/ Static Release Build (push) Has been skipped
Details
5b28711f3f
remove prints v2
Some checks failed
/ build_and_test (push) Failing after 34s
Details
/ Static Release Build (push) Has been skipped
Details
d89ebac4a6
Athamantis changed title from WIP: set_state_nic_nac to set_state_nic_nac 2026-03-17 14:31:13 +00:00
fix tests
All checks were successful
/ build_and_test (push) Successful in 37s
Details
/ Static Release Build (push) Has been skipped
Details
174dcbdbce
remove the nice driver
All checks were successful
/ build_and_test (push) Successful in 36s
Details
/ Static Release Build (push) Has been skipped
Details
2e611831b0
sebgab approved these changes 2026-03-17 14:41:52 +00:00
Dismissed
src/tasks/elevator_controller.rs Outdated
@ -195,0 +198,4 @@
// Check if door is closed, and wait for it to be
wait_for_door_to_be_closed(system_state.clone(), &mut elevator.clone()).await;
// {
sebgab commented 2026-03-17 14:41:36 +00:00
Owner
Copy link

Delete commented out code?

Delete commented out code?
Athamantis commented 2026-03-17 14:45:51 +00:00
Author
Owner
Copy link

fix in some commit

fix in some commit
Athamantis marked this conversation as resolved
remove uncommented code
All checks were successful
/ build_and_test (push) Successful in 37s
Details
/ Static Release Build (push) Has been skipped
Details
10a07e0412
Merge branch 'main' into set_state_nic_nac
All checks were successful
/ build_and_test (push) Successful in 36s
Details
/ Static Release Build (push) Has been skipped
Details
4ecc468580
sebgab requested review from sebgab 2026-03-17 14:46:06 +00:00
sebgab approved these changes 2026-03-17 14:47:47 +00:00
sebgab left a comment
Owner
Copy link

imageimage

![image](/attachments/ccd3c622-edb6-4b81-89c5-13fffc16d5ce)![image](/attachments/a021977e-14d9-4620-8289-ef8ebf9e54e1)
image.png
2 MiB
image.png
2 MiB
Hemmily requested changes 2026-03-17 14:47:50 +00:00
Dismissed
src/tasks/door_handler.rs Outdated
@ -65,2 +65,2 @@
debug!(
"Current doorstate is {:?}. Received message: {:?}",
trace!(
"Current doorstate is {:?}. Recieved message: {:?}",
Hemmily commented 2026-03-17 14:47:15 +00:00
Owner
Copy link

Received not recieved

Received not recieved
sebgab commented 2026-03-17 14:49:21 +00:00
Owner
Copy link

image
image

![image](/attachments/b1a7da12-e896-412a-a280-944d1c93d557) ![image](/attachments/6f864662-f4ce-4863-acd0-eb6ef3569e47)
image.png
45 KiB
image.png
80 KiB
sebgab commented 2026-03-17 14:50:32 +00:00
Owner
Copy link

image

![image](/attachments/aedd1554-154d-4e48-b38c-0facd1fb650e)
image.png
67 KiB
Athamantis marked this conversation as resolved
Received
All checks were successful
/ build_and_test (push) Successful in 38s
Details
/ Static Release Build (push) Has been skipped
Details
d1f612b304
Hemmily approved these changes 2026-03-17 14:51:09 +00:00
Hemmily left a comment
Owner
Copy link

image
image

![image](/attachments/9b4eb27f-cc7e-407d-a611-e6138f9665ef) ![image](/attachments/867f0009-7a40-4bf7-9f71-0ae9f16fdfe2)
image.png
269 KiB
image.png
58 KiB
Athamantis deleted branch set_state_nic_nac 2026-03-17 14:51:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
sebgab
Hemmily
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
priority
medium
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Athamantis
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TTK4145/elevator!43
No description provided.