TTK4145/elevator
3
0
Fork 0
Code Issues 1 Pull requests Projects 4 Releases 1 Packages Wiki Activity Actions

Implement door safety monitor #33

Merged
sebgab merged 4 commits from safety_monitor into main 2026-03-08 12:35:26 +00:00
Conversation 2 Commits 4 Files changed 4 +45 -1
sebgab commented 2026-03-08 12:03:22 +00:00
Owner
Copy link

Imeplements a runtime safety monitor that crashes the elevator program on an illegal condition.

Imeplements a runtime safety monitor that crashes the elevator program on an illegal condition.
Implement door safety monitor
Some checks failed
/ build_and_test (push) Failing after 23s
Details
/ Static Release Build (push) Has been skipped
Details
4ca51ee9cb
Only error and ignore request to close door when obstructed
Some checks failed
/ Static Release Build (push) Has been cancelled
Details
/ build_and_test (push) Has been cancelled
Details
de2b210dc2
Mark tests trying to close the door while obstructed as should panic
All checks were successful
/ build_and_test (push) Successful in 25s
Details
/ Static Release Build (push) Has been skipped
Details
e956341d80
Merge branch 'main' into safety_monitor
All checks were successful
/ build_and_test (push) Successful in 25s
Details
/ Static Release Build (push) Has been skipped
Details
6ff3aca828
Athamantis reviewed 2026-03-08 12:33:03 +00:00
src/safety_monitor.rs
@ -0,0 +24,4 @@
// Enforce that the door cannot be open while the elevator is moving
assert!(!(door_open && is_moving));
// Door not closing while obstructed is enforced in the `close_door` function
Athamantis commented 2026-03-08 12:32:41 +00:00
Owner
Copy link

non blocking: feels like a comment just randomly placed

non blocking: feels like a comment just randomly placed
sebgab commented 2026-03-08 12:34:43 +00:00
Author
Owner
Copy link

Moved to doccomment.

Moved to doccomment.
sebgab marked this conversation as resolved
Athamantis approved these changes 2026-03-08 12:34:58 +00:00
Athamantis left a comment
Owner
Copy link

lgtm

lgtm
sebgab merged commit 7370c48b3c into main 2026-03-08 12:35:26 +00:00
sebgab deleted branch safety_monitor 2026-03-08 12:35:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Athamantis
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
priority
medium
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TTK4145/elevator!33
No description provided.