TTK4145/elevator
3
0
Fork 0
Code Issues 1 Pull requests Projects 4 Releases 1 Packages Wiki Activity Actions

Create System State Controller #16

Merged
sebgab merged 15 commits from system-state-controler_datastructures into main 2026-02-11 17:29:50 +00:00
Conversation 6 Commits 15 Files changed 6 +1334 -2
sebgab commented 2026-02-10 14:04:17 +00:00
Owner
Copy link

Related to #4

Closes #10

Related to #4 Closes #10
Start creating state controller datastructures
All checks were successful
/ build_and_test (push) Successful in 24s
Details
1e7a04dd91 
See #10
Added more datastruct types after talking with group
All checks were successful
/ build_and_test (push) Successful in 24s
Details
d7622df5c1
More comments for datastructures
All checks were successful
/ build_and_test (push) Successful in 25s
Details
848453fe3e
Add SystemState datatype and impl ElevatorCall
Some checks failed
/ build_and_test (push) Failing after 18s
Details
37b455278c
Add usage example and add ElevatorCallInterface
Some checks failed
/ build_and_test (push) Failing after 22s
Details
dfa0ee9a52
Create test checking if state is smaller than max packet size
All checks were successful
/ build_and_test (push) Successful in 30s
Details
122110751b
Create ElevatorInterface
All checks were successful
/ build_and_test (push) Successful in 31s
Details
8a89516922
Add sample information for three elevators to size test
Some checks failed
/ build_and_test (push) Failing after 23s
Details
0aa4dbf1ac
Repalce UUID with small_uid
All checks were successful
/ build_and_test (push) Successful in 30s
Details
cc85b3e4c4
Add a couple more serialization related tests
All checks were successful
/ build_and_test (push) Successful in 31s
Details
aa0c7c075c
Update doccomment
All checks were successful
/ build_and_test (push) Successful in 31s
Details
7de4d8d8db
sebgab commented 2026-02-10 14:04:41 +00:00
Author
Owner
Copy link

Requesting review @Athamantis @Hemmily

Requesting review @Athamantis @Hemmily
Athamantis requested changes 2026-02-11 15:58:44 +00:00
Dismissed
src/main.rs
@ -8,0 +16,4 @@
use crate::system_state_controller::Destination;
async fn test_reader(state: Arc<RwLock<SystemState>>) {
Athamantis commented 2026-02-11 15:47:41 +00:00
Owner
Copy link

add commet, will it stay? or will it be removed

add commet, will it stay? or will it be removed
sebgab commented 2026-02-11 15:59:37 +00:00
Author
Owner
Copy link

This will be removed. It is just a test so that I could make a realistic sharing scenario for the System state when implementing the sharing mechanism.

This will be removed. It is just a test so that I could make a realistic sharing scenario for the System state when implementing the sharing mechanism.
sebgab marked this conversation as resolved
src/main.rs
@ -8,0 +23,4 @@
}
}
async fn test_writer(state: Arc<RwLock<SystemState>>, cabber: bool) {
Athamantis commented 2026-02-11 15:47:49 +00:00
Owner
Copy link

same here

same here
sebgab commented 2026-02-11 15:59:43 +00:00
Author
Owner
Copy link

This will be removed. It is just a test so that I could make a realistic sharing scenario for the System state when implementing the sharing mechanism.

This will be removed. It is just a test so that I could make a realistic sharing scenario for the System state when implementing the sharing mechanism.
sebgab marked this conversation as resolved
src/system_state_controller/mod.rs Outdated
@ -2,0 +138,4 @@
/// Get the elevator's current direction
pub fn get_direction(&self) -> Option<Direction> {
todo!("Implement")
}
Athamantis commented 2026-02-11 15:53:45 +00:00
Owner
Copy link

add function obstruction, and is_door_open? and close/open door?

get current floor?? and get_destination -> returns a floor?

add function obstruction, and is_door_open? and close/open door? get current floor?? and get_destination -> returns a floor?
sebgab commented 2026-02-11 17:07:24 +00:00
Author
Owner
Copy link

add function obstruction, and is_door_open? and close/open door?

Added and implemented in fd7bcb3.
These functions are abstracted through ElevatorInterface and ElevatorInfo

> add function obstruction, and is_door_open? and close/open door? Added and implemented in fd7bcb3. These functions are abstracted through ElevatorInterface and ElevatorInfo
sebgab commented 2026-02-11 17:10:41 +00:00
Author
Owner
Copy link

get current floor?? and get_destination -> returns a floor?

Yes, you are requesting which floor you are on, and then you get that floor.
Same goes for the destination, you get the floor we have as the destination.

> get current floor?? and get_destination -> returns a floor? Yes, you are requesting which floor you are on, and then you get _that_ floor. Same goes for the destination, you get the floor we have as the destination.
Hemmily approved these changes 2026-02-11 16:27:20 +00:00
Dismissed
Move functions into ElevatorInfo and ElevatorInterface
All checks were successful
/ build_and_test (push) Successful in 35s
Details
fd7bcb39a2
Update function definitions
All checks were successful
/ build_and_test (push) Successful in 32s
Details
6888666474
Add get destinatioon function and expose the elevator interface
All checks were successful
/ build_and_test (push) Successful in 32s
Details
e21af15f84
Athamantis approved these changes 2026-02-11 17:28:44 +00:00
Athamantis left a comment
Owner
Copy link

lgtm

lgtm
Hemmily approved these changes 2026-02-11 17:29:08 +00:00
Dismissed
Hemmily approved these changes 2026-02-11 17:29:30 +00:00
sebgab merged commit ed2434e4b0 into main 2026-02-11 17:29:50 +00:00
sebgab deleted branch system-state-controler_datastructures 2026-02-11 17:29:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Athamantis
Hemmily
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
priority
high

  
priority
low

  
priority
medium

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
priority
medium
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
System State Controller
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TTK4145/elevator!16
No description provided.