Merge I2C command handler into main #18

Merged
sebgab merged 15 commits from output-fan-data-over-i2c into main 2024-04-30 08:37:29 +00:00
Owner

Closes #10
Closes #8
Closes #4

Closes #10 Closes #8 Closes #4
sebgab added 9 commits 2024-04-27 13:41:16 +00:00
sebgab requested review from Athamantis 2024-04-27 13:41:23 +00:00
sebgab requested review from Inamr 2024-04-27 13:41:23 +00:00
Inamr approved these changes 2024-04-27 16:26:01 +00:00
Athamantis requested changes 2024-04-27 17:03:54 +00:00
@ -59,3 +59,3 @@
check_eeprom_is_ready();
if (fan_num == 1){
eeprom_update_byte(current_address_fan1, byte);
eeprom_write_byte(0x30, byte);
Owner

why write at a point? use current fan address so it can update the posision

why write at a point? use current fan address so it can update the posision
Author
Owner

Deleted in d31f03b6c7

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e
sebgab marked this conversation as resolved
@ -60,3 +60,3 @@
if (fan_num == 1){
eeprom_update_byte(current_address_fan1, byte);
eeprom_write_byte(0x30, byte);
current_address_fan1++;
Owner

either fix or delete

either fix or delete
Author
Owner

Deleted in d31f03b6c7

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e
sebgab marked this conversation as resolved
@ -100,0 +105,4 @@
if (fan_num == 1){
check_eeprom_is_ready();
return eeprom_read_byte(0x30 + pos);
Owner

start address, pos?

start address, pos?
Author
Owner

Deleted in d31f03b6c7

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e
sebgab marked this conversation as resolved
@ -41,3 +41,4 @@
// Reads all the dataPoints form EEPROM
uint8_t read_data_point_speed_info(uint8_t fan_num, uint8_t *array);
uint8_t read_single_data_point_speed_info(uint8_t fan_num, uint8_t pos);
Owner

what is pos???

what is pos???
Author
Owner

pos is data position, aka how many bytes into the readable area you want to read.

pos is data position, aka how many bytes into the readable area you want to read.
Author
Owner

Deleted in d31f03b6c7

Deleted in d31f03b6c76023518a2565d4114bb2e61ae0914e
sebgab marked this conversation as resolved
sebgab added 5 commits 2024-04-28 18:23:53 +00:00
sebgab requested review from Athamantis 2024-04-28 18:24:59 +00:00
sebgab added the due date 2024-04-29 2024-04-28 18:25:19 +00:00
Author
Owner

Closes #17

Closes #17
sebgab added 1 commit 2024-04-28 19:10:03 +00:00
Athamantis approved these changes 2024-04-29 06:47:28 +00:00
sebgab merged commit 495cbbba44 into main 2024-04-30 08:37:29 +00:00
sebgab deleted branch output-fan-data-over-i2c 2024-04-30 08:37:33 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

2024-04-29

Dependencies

No dependencies set.

Reference: Mikrokontrollersystemer-gruppe-4/mikrokontrollersystemer-prosjekt#18
No description provided.