sebgab
1 Followers · 2 Following
Repositories
10
 Projects Packages Public Activity Starred Repositories
sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

Add comments explaining the math.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

The function should be used based on the variable set earlier, rather than the perbuf being hardcoded.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

Remove commented out include.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

Remove unused define

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

Variable should be initialized to a value.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

This function should be used and it should calculate the ms with the formula from the øving.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

The last E should be removed.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

fanports is a bit confusing, maybe rename to fan_gpio?

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

ac0 and ac1 should be captialized, such that they are AC0.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

You should likely add yourself to the authors.

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

Remove duplicate include

sebgab commented on pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

Remove duplicate include

sebgab suggested changes for Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#19 2024-04-27 15:43:25 +00:00
fanspeed-comparator

Just a couple things

sebgab created pull request Mikrokontrollersy.../mikrokontrollersystemer-prosjekt#18 2024-04-27 13:41:16 +00:00
Merge I2C command handler into main
ae1c50ee09 Writing config works
f654ae96f6 Add case structure for better handling of future config params
dd624d4d48 Reading config parameter works
fb24365469 Prepare for write config
Compare 4 commits »
b8d19731ad Clear fan data works
822845cc7a Read temperature command works
1eaeeef9a0 Read temperature over I2C works
Compare 2 commits »
d964ebea37 Handle read single fan speed
bf3753a012 I2C bulk fan read works
Compare 2 commits »
sebgab pushed to master at Gitgals/C4-diagrams 2024-01-04 22:27:57 +00:00
89b7397520 Add demo deployment diagram