Miscellanious fixes #32
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
priority
high
priority
low
priority
medium
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
TTK4145/elevator!32
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "seb-fixes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
WIP: Miscellanious fixesto Miscellanious fixesCloses #8 #4 #28
@ -30,4 +36,2 @@move_elevator(system_state.clone(), &mut elevator.clone(), direction).await;current_floor_option = {let state = system_state.read().unwrap();@ -176,3 +202,3 @@match system_state.write().unwrap().start_servicing_call() {Ok(_) => {debug!("Succsessfully started servicing call");trace!("Successfully started servicing call");ah! at du våger!
(trenger ikke å endres)
@ -52,3 +52,3 @@let elev_num_floors = 4;let elevator = elev::Elevator::init("localhost:3113", elev_num_floors)let elevator = elev::Elevator::init("localhost:15657", elev_num_floors)02cry
@ -29,0 +28,4 @@tokio::task::yield_now().await;match sync_notification_rx.try_recv() {Ok(_) => return,Err(_) => {}ignoring error?
Added explanatory comment.
try_recv()errors if there is nothing to receive, which is the most common case. As such we just retry agiain.@ -29,0 +37,4 @@// of time has passed.tokio::select! {_ = recv(sync_notification_rx) => {trace!("TX due to notification");TX -> transmitting packets due to ---
Changed TX to "Transmitting"
@ -49,3 +49,3 @@doorstate_reciever: &mut mpsc::UnboundedReceiver<DoorState>,) {trace!("INFO: Awating message.");trace!("Awating message.");og du lurte på hvorfor jeg endret dine kommentar leveler...
@ -56,0 +84,4 @@.duration_since(v.to_owned()).unwrap();if should_dete {}?
nothing here
and plz should_dete??
add docks comment, and does this do anything?
lgtm
